-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ABI Calls support to ARC-0026 #310
Conversation
ARC4 ABI Calls are a necessary building block for decentralized SOA interoperability. The support is included in this commit.
Added Box Refference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks generally a good and useful addition.
I'm wondering, given that we are updating this spec, if wouldn't be a good opportunity to add not only a support for AppCall transactions but also for other transactions types (e.g. KeyRegistration).
Also, this makes me think that this spec does not clearly define a "transaction type" under which certain arguments are forbidden (e.g. trying to specify an method
under a Payment transaction request).
EDIT:
I have a lot of point TBD, like references to things that may change at runtime (depending on the execution path or the implementation), like: apps, boxes, accounts, assets, fees, etc.
I see these are being discussed on other channels, so I will defer my comments there.
Yes @cusma , avoiding other transaction types for app calls was intentional to avoid much unneccessary complexity and just have ABI calls in full supported by ARC 26 , which is long over due IMHO |
Co-authored-by: Cosimo Bassi <[email protected]>
Co-authored-by: Cosimo Bassi <[email protected]>
Co-authored-by: Cosimo Bassi <[email protected]>
I 100% agree but scenarios during which these ABI call URIs become useful are the ones in PR description: SOA interoperability and user-chain interaction. Example: A service or a dApp creates those in runtime based on a requirement and shows the QRCode to get user mobile consent during an interrupted flow (Like walletconnect itself) for security purposes. This PR especially can give rise to offline/indirect communications possibilities between dApps, services and users. |
Another great example would be Authenticate with your mobile device:
|
Please add network attribute with genesis name |
Lets please create arc260 for QRs with the protocol definition avm+web://arc260?txs=base64url([tx1,tx2,..]) where tx1 is the uint8 of the algosdk signed or unsigned tx. This will solve the issues
|
adding examples for the note field is out of this PRs scope but sure I will add those during weekend. |
There is an arc26-like implementation in the wild that implements keyregs, which would be good to standardize in light of incentives rolling out soon. |
Thank you so much @tasosbit. Great point and it will be added to this PR as soon as possible. |
I very much agree! @emg110 I had the same request in my previous comment. |
100% agree and WIP. It will be done ASAP. Million thanks @cusma |
Closed in favor of ARC -79 |
ABI Calls are a necessary building block for decentralized SOA interoperability and user-chain interaction. The support is included in this PR.